Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a117887

Browse filesBrowse files
hashseedgengjiawen
authored andcommitted
build: remove --build-v8-with-gn configure option
This option is now outdated and not used any longer. PR-URL: #27576 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 3b10f7f commit a117887
Copy full SHA for a117887

File tree

Expand file treeCollapse file tree

1 file changed

+0
-18
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-18
lines changed
Open diff view settings
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
-18Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@
4040
import getnapibuildversion
4141
from gyp_node import run_gyp
4242

43-
# imports in deps/v8/tools/node
44-
sys.path.insert(0, os.path.join('deps', 'v8', 'tools', 'node'))
45-
from fetch_deps import FetchDeps
46-
4743
# parse our options
4844
parser = optparse.OptionParser()
4945

@@ -679,12 +675,6 @@
679675
help='do not use V8 includes from the bundled deps folder. ' +
680676
'(This mode is not officially supported for regular applications)')
681677

682-
parser.add_option('--build-v8-with-gn',
683-
action='store_true',
684-
dest='build_v8_with_gn',
685-
default=False,
686-
help='build V8 using GN instead of gyp')
687-
688678
parser.add_option('--verbose',
689679
action='store_true',
690680
dest='verbose',
@@ -1347,14 +1337,6 @@ def configure_v8(o):
13471337
o['variables']['test_isolation_mode'] = 'noop' # Needed by d8.gyp.
13481338
if options.without_bundled_v8 and options.enable_d8:
13491339
raise Exception('--enable-d8 is incompatible with --without-bundled-v8.')
1350-
if options.without_bundled_v8 and options.build_v8_with_gn:
1351-
raise Exception(
1352-
'--build-v8-with-gn is incompatible with --without-bundled-v8.')
1353-
if options.build_v8_with_gn:
1354-
v8_path = os.path.join('deps', 'v8')
1355-
print('Fetching dependencies to build V8 with GN')
1356-
options.build_v8_with_gn = FetchDeps(v8_path)
1357-
o['variables']['build_v8_with_gn'] = b(options.build_v8_with_gn)
13581340

13591341

13601342
def configure_openssl(o):

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.