Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a07cd06

Browse filesBrowse files
nbdaaronMylesBorins
authored andcommitted
n-api: change assert ok check to notStrictEqual.
PR-URL: #18414 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 22093ab commit a07cd06
Copy full SHA for a07cd06

File tree

Expand file treeCollapse file tree

1 file changed

+7
-9
lines changed
Open diff view settings
Filter options
  • test/addons-napi/test_general
Expand file treeCollapse file tree

1 file changed

+7
-9
lines changed
Open diff view settings
Collapse file

‎test/addons-napi/test_general/test.js‎

Copy file name to clipboardExpand all lines: test/addons-napi/test_general/test.js
+7-9Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ assert.strictEqual(test_general.testGetPrototype(baseObject),
2828
Object.getPrototypeOf(baseObject));
2929
assert.strictEqual(test_general.testGetPrototype(extendedObject),
3030
Object.getPrototypeOf(extendedObject));
31-
assert.ok(test_general.testGetPrototype(baseObject) !==
32-
test_general.testGetPrototype(extendedObject),
33-
'Prototypes for base and extended should be different');
31+
// Prototypes for base and extended should be different.
32+
assert.notStrictEqual(test_general.testGetPrototype(baseObject),
33+
test_general.testGetPrototype(extendedObject));
3434

3535
// test version management functions
3636
// expected version is currently 1
@@ -70,17 +70,15 @@ assert.strictEqual(test_general.derefItemWasCalled(), true,
7070
// Assert that wrapping twice fails.
7171
const x = {};
7272
test_general.wrap(x);
73-
assert.throws(function() {
74-
test_general.wrap(x);
75-
}, Error);
73+
assert.throws(() => test_general.wrap(x), Error);
7674

7775
// Ensure that wrapping, removing the wrap, and then wrapping again works.
7876
const y = {};
7977
test_general.wrap(y);
8078
test_general.removeWrap(y);
81-
assert.doesNotThrow(function() {
82-
test_general.wrap(y);
83-
}, Error, 'Wrapping twice succeeds if a remove_wrap() separates the instances');
79+
assert.doesNotThrow(() => test_general.wrap(y), Error,
80+
'Wrapping twice succeeds if a remove_wrap()' +
81+
' separates the instances');
8482

8583
// Ensure that removing a wrap and garbage collecting does not fire the
8684
// finalize callback.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.