Commit 9fed62f
test: remove common.skipIfInspectorEnabled()
common.skipIfInspectorEnabled() is only used once in all of the tests.
The test is more clear (in my opinion, at least) without the abstraction
so put the check directly in the test. Additionally, it honestly looks
like an error (which is how I noticed it in the first place) and that
someone mistyped the far more common skipIfInspectorDisabled().
PR-URL: #29993
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>1 parent d9b5508 commit 9fed62fCopy full SHA for 9fed62f
File tree
Expand file treeCollapse file tree
2 files changed
+3
-8
lines changedOpen diff view settings
Filter options
- test
- common
- parallel
Expand file treeCollapse file tree
2 files changed
+3
-8
lines changedOpen diff view settings
Collapse file
-7Lines changed: 0 additions & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
651 | 651 | |
652 | 652 | |
653 | 653 | |
654 | | - |
655 | | - |
656 | | - |
657 | | - |
658 | | - |
659 | | - |
660 | 654 | |
661 | 655 | |
662 | 656 | |
| ||
789 | 783 | |
790 | 784 | |
791 | 785 | |
792 | | - |
793 | 786 | |
794 | 787 | |
795 | 788 | |
|
Collapse file
test/parallel/test-coverage-with-inspector-disabled.js
Copy file name to clipboardExpand all lines: test/parallel/test-coverage-with-inspector-disabled.js+3-1Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
3 | 3 | |
4 | | - |
| 4 | + |
| 5 | + |
| 6 | + |
5 | 7 | |
6 | 8 | |
7 | 9 | |
|
0 commit comments