Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9fb6cf0

Browse filesBrowse files
JeffMarvinMylesBorins
authored andcommitted
test: correct assertion argument order
This conforms assertions to follow the argument order of asserted then actual, and adds more explicit messages to describe assertion failures. PR-URL: #23618 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent 4f8e4f0 commit 9fb6cf0
Copy full SHA for 9fb6cf0

File tree

Expand file treeCollapse file tree

1 file changed

+30
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+30
-6
lines changed
Open diff view settings
Collapse file

‎test/sequential/test-inspector.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-inspector.js
+30-6Lines changed: 30 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,12 @@ const assert = require('assert');
88
const { NodeInstance } = require('../common/inspector-helper.js');
99

1010
function checkListResponse(response) {
11-
assert.strictEqual(1, response.length);
11+
const expectedLength = 1;
12+
assert.strictEqual(
13+
response.length,
14+
expectedLength,
15+
`Expected response length ${response.length} to be ${expectedLength}.`
16+
);
1217
assert.ok(response[0].devtoolsFrontendUrl);
1318
assert.ok(
1419
/ws:\/\/localhost:\d+\/[0-9A-Fa-f]{8}-/
@@ -41,7 +46,11 @@ function assertScopeValues({ result }, expected) {
4146
for (const actual of result) {
4247
const value = expected[actual.name];
4348
if (value) {
44-
assert.strictEqual(value, actual.value.value);
49+
assert.strictEqual(
50+
actual.value.value,
51+
value,
52+
`Expected scope values to be ${actual.value.value} instead of ${value}.`
53+
);
4554
unmatched.delete(actual.name);
4655
}
4756
}
@@ -117,15 +126,24 @@ async function testBreakpoint(session) {
117126
'generatePreview': true
118127
}
119128
});
120-
121-
assert.strictEqual(1002, result.value);
129+
const expectedEvaluation = 1002;
130+
assert.strictEqual(
131+
result.value,
132+
expectedEvaluation,
133+
`Expected evaluation to be ${expectedEvaluation}, got ${result.value}.`
134+
);
122135

123136
result = (await session.send({
124137
'method': 'Runtime.evaluate', 'params': {
125138
'expression': '5 * 5'
126139
}
127140
})).result;
128-
assert.strictEqual(25, result.value);
141+
const expectedResult = 25;
142+
assert.strictEqual(
143+
result.value,
144+
expectedResult,
145+
`Expected Runtime.evaluate to be ${expectedResult}, got ${result.value}.`
146+
);
129147
}
130148

131149
async function testI18NCharacters(session) {
@@ -288,7 +306,13 @@ async function runTest() {
288306
await testI18NCharacters(session);
289307
await testCommandLineAPI(session);
290308
await session.runToCompletion();
291-
assert.strictEqual(55, (await child.expectShutdown()).exitCode);
309+
const expectedExitCode = 55;
310+
const { exitCode } = await child.expectShutdown();
311+
assert.strictEqual(
312+
exitCode,
313+
expectedExitCode,
314+
`Expected exit code to be ${expectedExitCode} but got ${expectedExitCode}.`
315+
);
292316
}
293317

294318
runTest();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.