Commit 9f282dd
deps: cherry-pick 1420e44db0 from upstream V8
Original commit message:
[coverage] Correctly free DebugInfo in the absence of breakpoints
It's quite possible for DebugInfos to exist without the presence of a
bytecode array, since DebugInfos are created for all functions for which
we have a CoverageInfo. Free such objects properly.
Also move the corresponding deletion of CoverageInfos on unload up
before the early exit.
Bug: v8:6000
Change-Id: Idde45b222290aa8b6828b61ff2251918b8ed2aed
Reviewed-on: https://chromium-review.googlesource.com/664811
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48024}
Fixes crash when passing Profiler.startPreciseCoverage before
Debug.paused is received.
PR-URL: #17344
Refs: v8/v8@1420e44
Refs: bcoe/c8#6 (comment)
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 6a7a59a commit 9f282ddCopy full SHA for 9f282dd
File tree
Expand file treeCollapse file tree
2 files changed
+6
-4
lines changedOpen diff view settings
Filter options
- deps/v8/src/debug
Expand file treeCollapse file tree
2 files changed
+6
-4
lines changedOpen diff view settings
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
27 | 27 | |
28 | 28 | |
29 | 29 | |
30 | | - |
| 30 | + |
31 | 31 | |
32 | 32 | |
33 | 33 | |
|
Collapse file
+5-3Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
338 | 338 | |
339 | 339 | |
340 | 340 | |
| 341 | + |
341 | 342 | |
342 | 343 | |
343 | 344 | |
344 | 345 | |
345 | 346 | |
346 | | - |
347 | | - |
348 | 347 | |
349 | 348 | |
350 | 349 | |
| ||
643 | 642 | |
644 | 643 | |
645 | 644 | |
| 645 | + |
| 646 | + |
| 647 | + |
| 648 | + |
646 | 649 | |
647 | | - |
648 | 650 | |
649 | 651 | |
650 | 652 | |
|
0 commit comments