Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9ed7d2e

Browse filesBrowse files
lundibunditargos
authored andcommitted
test: log errors in test-http2-propagate-session-destroy-code
PR-URL: #31072 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 6c9bc3c commit 9ed7d2e
Copy full SHA for 9ed7d2e

File tree

Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-http2-propagate-session-destroy-code.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http2-propagate-session-destroy-code.js
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@ server.on('error', common.mustNotCall());
1515
server.on('session', (session) => {
1616
session.on('close', common.mustCall());
1717
session.on('error', common.mustCall((err) => {
18-
assert(errRegEx.test(err));
18+
assert.ok(errRegEx.test(err), `server session err: ${err}`);
1919
assert.strictEqual(session.closed, false);
2020
assert.strictEqual(session.destroyed, true);
2121
}));
2222

2323
session.on('stream', common.mustCall((stream) => {
2424
stream.on('error', common.mustCall((err) => {
25+
assert.ok(errRegEx.test(err), `server stream err: ${err}`);
2526
assert.strictEqual(session.closed, false);
2627
assert.strictEqual(session.destroyed, true);
27-
assert(errRegEx.test(err));
2828
assert.strictEqual(stream.rstCode, destroyCode);
2929
}));
3030

@@ -36,15 +36,15 @@ server.listen(0, common.mustCall(() => {
3636
const session = http2.connect(`http://localhost:${server.address().port}`);
3737

3838
session.on('error', common.mustCall((err) => {
39-
assert(errRegEx.test(err));
39+
assert.ok(errRegEx.test(err), `client session err: ${err}`);
4040
assert.strictEqual(session.closed, false);
4141
assert.strictEqual(session.destroyed, true);
4242
}));
4343

4444
const stream = session.request({ [http2.constants.HTTP2_HEADER_PATH]: '/' });
4545

4646
stream.on('error', common.mustCall((err) => {
47-
assert(errRegEx.test(err));
47+
assert.ok(errRegEx.test(err), `client stream err: ${err}`);
4848
assert.strictEqual(stream.rstCode, destroyCode);
4949
}));
5050

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.