Commit 9e3e676
module: port source map sort logic from chromium
Digging in to the delta between V8's source map library, and chromium's
the most significant difference that jumped out at me was that we were
failing to sort generated columns. Since negative offsets are not
restricted in the spec, this can lead to bugs.
fixes: #31286
PR-URL: #31927
Fixes: #31286
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 6a35b0d commit 9e3e676Copy full SHA for 9e3e676
File tree
Expand file treeCollapse file tree
2 files changed
+44
-2
lines changedOpen diff view settings
Filter options
- lib/internal/source_map
- test/parallel
Expand file treeCollapse file tree
2 files changed
+44
-2
lines changedOpen diff view settings
Collapse file
lib/internal/source_map/source_map.js
Copy file name to clipboardExpand all lines: lib/internal/source_map/source_map.js+19-2Lines changed: 19 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
152 | 152 | |
153 | 153 | |
154 | 154 | |
155 | | - |
| 155 | + |
156 | 156 | |
157 | | - |
| 157 | + |
158 | 158 | |
| 159 | + |
| 160 | + |
159 | 161 | |
160 | 162 | |
161 | 163 | |
| ||
321 | 323 | |
322 | 324 | |
323 | 325 | |
| 326 | + |
| 327 | + |
| 328 | + |
| 329 | + |
| 330 | + |
| 331 | + |
| 332 | + |
| 333 | + |
| 334 | + |
| 335 | + |
| 336 | + |
| 337 | + |
| 338 | + |
| 339 | + |
| 340 | + |
324 | 341 | |
325 | 342 | |
326 | 343 | |
Collapse file
test/parallel/test-source-map-api.js
Copy file name to clipboardExpand all lines: test/parallel/test-source-map-api.js+25Lines changed: 25 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
124 | 124 | |
125 | 125 | |
126 | 126 | |
| 127 | + |
| 128 | + |
| 129 | + |
| 130 | + |
| 131 | + |
| 132 | + |
| 133 | + |
| 134 | + |
| 135 | + |
| 136 | + |
| 137 | + |
| 138 | + |
| 139 | + |
| 140 | + |
| 141 | + |
| 142 | + |
| 143 | + |
| 144 | + |
| 145 | + |
| 146 | + |
| 147 | + |
| 148 | + |
| 149 | + |
| 150 | + |
| 151 | + |
0 commit comments