Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9e1dcdc

Browse filesBrowse files
committed
src: remove NodeCategorySet destructor
This currently crashes during environment cleanup because the object would be torn down while there are enabled categories. I’m not sure about the exact semantics here, but since the object cannot be garbage collected at this point anyway because it’s `Persistent` handle is strong, removing the destructor at least doesn’t make anything worse than it is right now (i.e. the destructor would never have been called before anyway). PR-URL: #19377 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 97d939a commit 9e1dcdc
Copy full SHA for 9e1dcdc

File tree

Expand file treeCollapse file tree

1 file changed

+0
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-5
lines changed
Open diff view settings
Collapse file

‎src/node_trace_events.cc‎

Copy file name to clipboardExpand all lines: src/node_trace_events.cc
-5Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@ using v8::Value;
2121

2222
class NodeCategorySet : public BaseObject {
2323
public:
24-
~NodeCategorySet() override {
25-
// Verify that the thing was properly disabled before gc
26-
CHECK_NE(enabled_, true);
27-
}
28-
2924
static void New(const FunctionCallbackInfo<Value>& args);
3025
static void Enable(const FunctionCallbackInfo<Value>& args);
3126
static void Disable(const FunctionCallbackInfo<Value>& args);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.