Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9dbb255

Browse filesBrowse files
geeksilva97aduh95
authored andcommitted
assert: fix deepStrictEqual on errors when cause is not undefined
PR-URL: #55406 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 7d93c0c commit 9dbb255
Copy full SHA for 9dbb255

File tree

Expand file treeCollapse file tree

2 files changed

+50
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+50
-0
lines changed
Open diff view settings
Collapse file

‎lib/internal/assert/assertion_error.js‎

Copy file name to clipboardExpand all lines: lib/internal/assert/assertion_error.js
+11Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ const {
1515
StringPrototypeSplit,
1616
} = primordials;
1717

18+
const { isError } = require('internal/util');
19+
1820
const { inspect } = require('internal/util/inspect');
1921
const colors = require('internal/util/colors');
2022
const { validateObject } = require('internal/validators');
@@ -47,6 +49,15 @@ function copyError(source) {
4749
__proto__: null,
4850
value: source.message,
4951
});
52+
if (source.cause !== undefined) {
53+
let cause = source.cause;
54+
55+
if (isError(cause)) {
56+
cause = copyError(cause);
57+
}
58+
59+
ObjectDefineProperty(target, 'cause', { __proto__: null, value: cause });
60+
}
5061
return target;
5162
}
5263

Collapse file
+39Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
'use strict';
2+
require('../common');
3+
const assert = require('assert');
4+
const { test } = require('node:test');
5+
6+
const defaultStartMessage = 'Expected values to be strictly deep-equal:\n' +
7+
'+ actual - expected\n' +
8+
'\n';
9+
10+
test('Handle error causes', () => {
11+
assert.throws(() => {
12+
assert.deepStrictEqual(new Error('a', { cause: new Error('x') }), new Error('a', { cause: new Error('y') }));
13+
}, { message: defaultStartMessage + ' [Error: a] {\n' +
14+
'+ [cause]: [Error: x]\n' +
15+
'- [cause]: [Error: y]\n' +
16+
' }\n' });
17+
18+
assert.throws(() => {
19+
assert.deepStrictEqual(new Error('a'), new Error('a', { cause: new Error('y') }));
20+
}, { message: defaultStartMessage + '+ [Error: a]\n' +
21+
'- [Error: a] {\n' +
22+
'- [cause]: [Error: y]\n' +
23+
'- }\n' });
24+
25+
assert.throws(() => {
26+
assert.deepStrictEqual(new Error('a'), new Error('a', { cause: { prop: 'value' } }));
27+
}, { message: defaultStartMessage + '+ [Error: a]\n' +
28+
'- [Error: a] {\n' +
29+
'- [cause]: {\n' +
30+
'- prop: \'value\'\n' +
31+
'- }\n' +
32+
'- }\n' });
33+
34+
assert.notDeepStrictEqual(new Error('a', { cause: new Error('x') }), new Error('a', { cause: new Error('y') }));
35+
assert.notDeepStrictEqual(
36+
new Error('a', { cause: { prop: 'value' } }),
37+
new Error('a', { cause: { prop: 'a different value' } })
38+
);
39+
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.