Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 9c9138f

Browse filesBrowse files
dmabupttargos
dmabupt
authored and
targos
committed
test: skip the unsupported test cases for IBM i
This is a following PR of #30714. PR-URL: #30819 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 2aab93e commit 9c9138f
Copy full SHA for 9c9138f
Expand file treeCollapse file tree

29 files changed

+108
-21
lines changed
Open diff view settings
Collapse file

‎test/async-hooks/test-fseventwrap.js‎

Copy file name to clipboardExpand all lines: test/async-hooks/test-fseventwrap.js
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ const fs = require('fs');
1010
if (!common.isMainThread)
1111
common.skip('Worker bootstrapping works differently -> different async IDs');
1212

13+
if (common.isIBMi)
14+
common.skip('IBMi does not suppport fs.watch()');
15+
1316
const hooks = initHooks();
1417

1518
hooks.enable();
Collapse file

‎test/parallel/parallel.status‎

Copy file name to clipboardExpand all lines: test/parallel/parallel.status
+9Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,12 @@ test-async-hooks-http-parser-destroy: PASS,FLAKY
4343
[$system==freebsd]
4444

4545
[$system==aix]
46+
47+
[$system==ibmi]
48+
# https://github.com/nodejs/node/pull/30819
49+
test-child-process-fork-net-server: SKIP
50+
test-cli-node-options: SKIP
51+
test-cluster-shared-leak: SKIP
52+
test-http-writable-true-after-close: SKIP
53+
test-http2-connect-method: SKIP
54+
test-net-error-twice: SKIP
Collapse file

‎test/parallel/test-c-ares.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-c-ares.js
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ dns.lookup('::1', common.mustCall((error, result, addressType) => {
8585
// Windows doesn't usually have an entry for localhost 127.0.0.1 in
8686
// C:\Windows\System32\drivers\etc\hosts
8787
// so we disable this test on Windows.
88-
if (!common.isWindows) {
88+
// IBMi reports `ENOTFOUND` when get hostname by address 127.0.0.1
89+
if (!common.isWindows && !common.isIBMi) {
8990
dns.reverse('127.0.0.1', common.mustCall(function(error, domains) {
9091
assert.ifError(error);
9192
assert.ok(Array.isArray(domains));
Collapse file

‎test/parallel/test-child-process-spawnsync-validation-errors.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-spawnsync-validation-errors.js
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ const common = require('../common');
33
const assert = require('assert');
44
const spawnSync = require('child_process').spawnSync;
55
const signals = require('os').constants.signals;
6-
const rootUser = common.isWindows ? false : process.getuid() === 0;
6+
const rootUser = common.isWindows ? false :
7+
common.isIBMi ? true : process.getuid() === 0;
78

89
const invalidArgTypeError = common.expectsError(
910
{ code: 'ERR_INVALID_ARG_TYPE', type: TypeError },
Collapse file

‎test/parallel/test-child-process-uid-gid.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-uid-gid.js
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ const assert = require('assert');
44
const spawn = require('child_process').spawn;
55
const expectedError = common.isWindows ? /\bENOTSUP\b/ : /\bEPERM\b/;
66

7+
if (common.isIBMi)
8+
common.skip('IBMi has a different behavior');
9+
710
if (common.isWindows || process.getuid() !== 0) {
811
assert.throws(() => {
912
spawn('echo', ['fhqwhgads'], { uid: 0 });
Collapse file

‎test/parallel/test-cluster-shared-handle-bind-privileged-port.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cluster-shared-handle-bind-privileged-port.js
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ const common = require('../common');
2626
if (common.isOSX)
2727
common.skip('macOS may allow ordinary processes to use any port');
2828

29+
if (common.isIBMi)
30+
common.skip('IBMi may allow ordinary processes to use any port');
31+
2932
if (common.isWindows)
3033
common.skip('not reliable on Windows');
3134

Collapse file

‎test/parallel/test-fs-access.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-access.js
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ const common = require('../common');
88
if (!common.isWindows && process.getuid() === 0)
99
common.skip('as this test should not be run as `root`');
1010

11+
if (common.isIBMi)
12+
common.skip('IBMi has a different access permission mechanism');
13+
1114
const assert = require('assert');
1215
const fs = require('fs');
1316
const path = require('path');
Collapse file

‎test/parallel/test-fs-copyfile-respect-permissions.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-copyfile-respect-permissions.js
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ const common = require('../common');
88
if (!common.isWindows && process.getuid() === 0)
99
common.skip('as this test should not be run as `root`');
1010

11+
if (common.isIBMi)
12+
common.skip('IBMi has a different access permission mechanism');
13+
1114
const tmpdir = require('../common/tmpdir');
1215
tmpdir.refresh();
1316

Collapse file

‎test/parallel/test-fs-options-immutable.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-options-immutable.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ if (common.canCreateSymLink()) {
4646
fs.appendFile(fileName, 'ABCD', options, common.mustCall(errHandler));
4747
}
4848

49-
{
49+
if (!common.isIBMi) { // IBMi does not suppport fs.watch()
5050
const watch = fs.watch(__filename, options, common.mustNotCall());
5151
watch.close();
5252
}
Collapse file

‎test/parallel/test-fs-utimes.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-utimes.js
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,9 @@ function runTests(iter) {
144144
const path = `${tmpdir.path}/test-utimes-precision`;
145145
fs.writeFileSync(path, '');
146146

147-
// Test Y2K38 for all platforms [except 'arm', 'OpenBSD' and 'SunOS']
148-
if (!process.arch.includes('arm') && !common.isOpenBSD && !common.isSunOS) {
147+
// Test Y2K38 for all platforms [except 'arm', 'OpenBSD', 'SunOS' and 'IBMi']
148+
if (!process.arch.includes('arm') &&
149+
!common.isOpenBSD && !common.isSunOS && !common.isIBMi) {
149150
const Y2K38_mtime = 2 ** 31;
150151
fs.utimesSync(path, Y2K38_mtime, Y2K38_mtime);
151152
const Y2K38_stats = fs.statSync(path);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.