Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 9b3c115

Browse filesBrowse files
targostargos
committed
deps: V8: cherry-pick 3b8c624
Original commit message: GCC: explicitely instantiate JSObject::ApplyAttributesToDictionary for NumberDictionary elements.cc invokes ApplyAttributesToDictionary using NumberDictionary as its template parameter. But the declaration of the template method is in js-object.cc, so nobody can actually compile the version for number dictionary. This is fixed requesting explicit instantiation for NumberDictionary. This was breaking GCC build. Bug: chromium:819294 Change-Id: I685ddc5b97e129d1a534dbdb04025c0932bc5ecd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649565 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#62097} Refs: v8/v8@3b8c624 Backport-PR-URL: #28955 PR-URL: #28016 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 533b2d4 commit 9b3c115
Copy full SHA for 9b3c115

File tree

Expand file treeCollapse file tree

3 files changed

+6
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+6
-1
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.10',
41+
'v8_embedder_string': '-node.11',
4242

4343
##### V8 defaults for Node.js #####
4444

Collapse file

‎deps/v8/AUTHORS‎

Copy file name to clipboardExpand all lines: deps/v8/AUTHORS
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ NVIDIA Corporation <*@nvidia.com>
1515
BlackBerry Limited <*@blackberry.com>
1616
Opera Software ASA <*@opera.com>
1717
Intel Corporation <*@intel.com>
18+
LG Electronics, Inc. <*@lge.com>
1819
Microsoft <*@microsoft.com>
1920
MIPS Technologies, Inc. <*@mips.com>
2021
Imagination Technologies, LLC <*@imgtec.com>
Collapse file

‎deps/v8/src/objects/js-objects.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/objects/js-objects.cc
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3752,6 +3752,10 @@ void JSObject::ApplyAttributesToDictionary(
37523752
}
37533753
}
37543754

3755+
template void JSObject::ApplyAttributesToDictionary(
3756+
Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
3757+
const PropertyAttributes attributes);
3758+
37553759
template <PropertyAttributes attrs>
37563760
Maybe<bool> JSObject::PreventExtensionsWithTransition(
37573761
Handle<JSObject> object, ShouldThrow should_throw) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.