Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9b02f36

Browse filesBrowse files
lal12targos
authored andcommitted
deps: dlloads node static linked executable
OpenSSL dlloads itself to prevent unloading, in case it might be dynamically loaded. However when linked statically this will lead to dloading the main executable. Refs: #21848 (comment) PR-URL: #28045 Fixes: #27925 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent b282c85 commit 9b02f36
Copy full SHA for 9b02f36

File tree

Expand file treeCollapse file tree

1 file changed

+12
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+12
-0
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+12Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -501,6 +501,18 @@
501501
'-Wl,--export-dynamic',
502502
],
503503
}],
504+
# if node is built as an executable,
505+
# the openssl mechanism for keeping itself "dload"-ed to ensure proper
506+
# atexit cleanup does not apply
507+
['node_shared_openssl!="true" and node_shared!="true"', {
508+
'defines': [
509+
# `OPENSSL_NO_PINSHARED` prevents openssl from dload
510+
# current node executable,
511+
# see https://github.com/nodejs/node/pull/21848
512+
# or https://github.com/nodejs/node/issues/27925
513+
'OPENSSL_NO_PINSHARED'
514+
],
515+
}],
504516
['node_shared_openssl!="true"', {
505517
# `OPENSSL_THREADS` is defined via GYP for openSSL for all architectures.
506518
'defines': [

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.