Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9abcead

Browse filesBrowse files
trevnorrisrvagg
authored andcommitted
node: fix leaking Context handle
The call to node::Environment::GetCurrent(Isolate*) makes the call to v8::Isolate::GetCurrentContext(). Doing so creates a new handle that bubbled to the v8::SealHandleScope(). PR-URL: #3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>
1 parent 409f6a9 commit 9abcead
Copy full SHA for 9abcead

File tree

Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3163,6 +3163,7 @@ static void EnableDebug(Environment* env) {
31633163

31643164
// Called from the main thread.
31653165
static void DispatchDebugMessagesAsyncCallback(uv_async_t* handle) {
3166+
HandleScope scope(node_isolate);
31663167
if (debugger_running == false) {
31673168
fprintf(stderr, "Starting debugger agent.\n");
31683169

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.