Commit 9a192a9
net: fix ambiguity in EOF handling
`end` MUST always be emitted **before** `close`. However, if a handle
will invoke `uv_close_cb` immediately, or in the same JS tick - `close`
may be emitted first.
PR-URL: #9066
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>1 parent 4de7a6e commit 9a192a9Copy full SHA for 9a192a9
File tree
Expand file treeCollapse file tree
2 files changed
+31
-3
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+31
-3
lines changedOpen diff view settings
Collapse file
+5-3Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
560 | 560 | |
561 | 561 | |
562 | 562 | |
| 563 | + |
| 564 | + |
| 565 | + |
| 566 | + |
| 567 | + |
563 | 568 | |
564 | 569 | |
565 | 570 | |
566 | 571 | |
567 | 572 | |
568 | | - |
569 | | - |
570 | | - |
571 | 573 | |
572 | 574 | |
573 | 575 | |
|
Collapse file
test/parallel/test-net-end-close.js
Copy file name to clipboard+26Lines changed: 26 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
0 commit comments