Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 99a09a2

Browse filesBrowse files
mcollinatargos
authored andcommitted
http: add captureRejection support to OutgoingMessage
PR-URL: #27867 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent cdc33df commit 99a09a2
Copy full SHA for 99a09a2

File tree

Expand file treeCollapse file tree

2 files changed

+95
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+95
-0
lines changed
Open diff view settings
Collapse file

‎lib/_http_outgoing.js‎

Copy file name to clipboardExpand all lines: lib/_http_outgoing.js
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const {
3333

3434
const { getDefaultHighWaterMark } = require('internal/streams/state');
3535
const assert = require('internal/assert');
36+
const EE = require('events');
3637
const Stream = require('stream');
3738
const internalUtil = require('internal/util');
3839
const { kOutHeaders, utcDate, kNeedDrain } = require('internal/http');
@@ -869,6 +870,11 @@ OutgoingMessage.prototype.pipe = function pipe() {
869870
this.emit('error', new ERR_STREAM_CANNOT_PIPE());
870871
};
871872

873+
OutgoingMessage.prototype[EE.captureRejectionSymbol] =
874+
function(err, event) {
875+
this.destroy(err);
876+
};
877+
872878
module.exports = {
873879
OutgoingMessage
874880
};
Collapse file
+89Lines changed: 89 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,89 @@
1+
'use strict';
2+
3+
const common = require('../common');
4+
const assert = require('assert');
5+
const events = require('events');
6+
const { createServer, request } = require('http');
7+
8+
events.captureRejections = true;
9+
10+
{
11+
const server = createServer(common.mustCall((req, res) => {
12+
const _err = new Error('kaboom');
13+
res.on('drain', common.mustCall(async () => {
14+
throw _err;
15+
}));
16+
17+
res.socket.on('error', common.mustCall((err) => {
18+
assert.strictEqual(err, _err);
19+
}));
20+
21+
// Write until there is space in the buffer
22+
while (res.write('hello')) {}
23+
}));
24+
25+
server.listen(0, common.mustCall(() => {
26+
const req = request({
27+
method: 'GET',
28+
host: server.address().host,
29+
port: server.address().port
30+
});
31+
32+
req.end();
33+
34+
req.on('response', common.mustCall((res) => {
35+
res.on('aborted', common.mustCall());
36+
res.resume();
37+
server.close();
38+
}));
39+
}));
40+
}
41+
42+
{
43+
let _res;
44+
let shouldEnd = false;
45+
// Not using mustCall here, because it is OS-dependant.
46+
const server = createServer((req, res) => {
47+
// So that we cleanly stop
48+
_res = res;
49+
50+
if (shouldEnd) {
51+
res.end();
52+
}
53+
});
54+
55+
server.listen(0, common.mustCall(() => {
56+
const _err = new Error('kaboom');
57+
58+
const req = request({
59+
method: 'POST',
60+
host: server.address().host,
61+
port: server.address().port
62+
});
63+
64+
req.on('response', common.mustNotCall((res) => {
65+
// So that we cleanly stop
66+
res.resume();
67+
server.close();
68+
}));
69+
70+
req.on('error', common.mustCall((err) => {
71+
server.close();
72+
// On some variants of Windows, this can happen before
73+
// the server has received the request.
74+
if (_res) {
75+
_res.end();
76+
} else {
77+
shouldEnd = true;
78+
}
79+
assert.strictEqual(err, _err);
80+
}));
81+
82+
req.on('drain', common.mustCall(async () => {
83+
throw _err;
84+
}));
85+
86+
// Write until there is space in the buffer
87+
while (req.write('hello')) {}
88+
}));
89+
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.