Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 993c0db

Browse filesBrowse files
addaleaxtargos
authored andcommitted
test: make sure test function resolves in test-worker-debug
Use the common `.then(common.mustCall())` check to verify that. Also, we should not use `process.abort()` in `test/parallel`; if the test fails, that leaves core dumps lying around on POSIX systems. PR-URL: #28155 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent dec5b22 commit 993c0db
Copy full SHA for 993c0db

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-worker-debug.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-worker-debug.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ async function testWaitForDisconnectInWorker(session, post) {
272272

273273
session.disconnect();
274274
console.log('Test done');
275-
})().catch((err) => {
275+
})().then(common.mustCall()).catch((err) => {
276276
console.error(err);
277-
process.abort();
277+
process.exitCode = 1;
278278
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.