Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 97d1fc0

Browse filesBrowse files
Fishrock123Myles Borins
authored andcommitted
doc: improve onboarding-extras.md formatting
Fixes some formatting, improves some formatting, updates minor nits. Refs: #6655 PR-URL: #6548 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent c9b144d commit 97d1fc0
Copy full SHA for 97d1fc0

File tree

Expand file treeCollapse file tree

1 file changed

+22
-22
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+22
-22
lines changed
Open diff view settings
Collapse file

‎doc/onboarding-extras.md‎

Copy file name to clipboardExpand all lines: doc/onboarding-extras.md
+22-22Lines changed: 22 additions & 22 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,24 @@
11
## Who to CC in issues
22

3-
* `lib/buffer`: @trevnorris
4-
* `lib/child_process`: @cjihrig, @bnoordhuis, @piscisaereus
5-
* `lib/cluster`: @cjihrig, @bnoordhuis, @piscisaereus
6-
* `lib/{crypto,tls,https}`: @indutny, @shigeki, @nodejs/crypto
7-
* `lib/domains`: @misterdjules
8-
* `lib/{_}http{*}`: @indutny, @bnoordhuis, @nodejs/http
9-
* `lib/net`: @indutny, @bnoordhuis, @piscisaereus, @chrisdickinson, @nodejs/streams
10-
* `lib/{_}stream{s|*}`: @nodejs/streams
11-
* `lib/repl`: @fishrock123
12-
* `lib/timers`: @fishrock123, @misterdjules
13-
* `lib/zlib`: @indutny, @bnoordhuis
14-
15-
* `src/async-wrap.*`: @trevnorris
16-
* `src/node_crypto.*`: @indutny, @shigeki, @nodejs/crypto
17-
18-
* `test/*`: @nodejs/testing, @trott
19-
20-
* `tools/eslint`, `.eslintrc`: @silverwind, @trott
21-
22-
* upgrading v8: @bnoordhuis / @targos / @ofrobots
23-
* upgrading npm: @thealphanerd, @fishrock123
3+
| subsystem | maintainers |
4+
| --- | --- |
5+
| `lib/buffer` | @trevnorris |
6+
| `lib/child_process` | @cjihrig, @bnoordhuis |
7+
| `lib/cluster` | @cjihrig, @bnoordhuis |
8+
| `lib/{crypto,tls,https}` | @nodejs/crypto |
9+
| `lib/domains` | @misterdjules |
10+
| `lib/{_}http{*}` | @indutny, @bnoordhuis, @mscdex, @nodejs/http |
11+
| `lib/net` | @indutny, @bnoordhuis, @nodejs/streams |
12+
| `lib/{_}stream{s|*}` | @nodejs/streams |
13+
| `lib/repl` | @fishrock123 |
14+
| `lib/timers` | @fishrock123, @misterdjules |
15+
| `lib/zlib` | @indutny, @bnoordhuis |
16+
| `src/async-wrap.*` | @trevnorris |
17+
| `src/node_crypto.*` | @nodejs/crypto |
18+
| `test/*` | @nodejs/testing |
19+
| `tools/eslint`, `.eslintrc` | @silverwind, @trott |
20+
| upgrading v8 | @bnoordhuis, @targos, @ofrobots |
21+
| upgrading npm | @thealphanerd, @fishrock123 |
2422

2523

2624
When things need extra attention, are controversial, or `semver-major`: @nodejs/ctc
@@ -52,6 +50,8 @@ Please use these when possible / appropriate
5250
* `feature request` - Any issue that requests a new feature (usually not PRs)
5351
* `good first contribution` - Issues suitable for newcomers to process
5452

53+
--
54+
5555
* `semver-{minor,major}`
5656
* be conservative – that is, if a change has the remote *chance* of breaking something, go for semver-major
5757
* when adding a semver label, add a comment explaining why you're adding it
@@ -94,7 +94,7 @@ to update from nodejs/node:
9494
* prefer to make the originating user update the code, since they have it fresh in mind
9595
* first, reattempt with `git am -3` (3-way merge)`
9696
* if `-3` still fails, and you need to get it merged:
97-
* `git fetch origin pull/N/head:pr-N && git checkout pr-N && git rebase master`
97+
* `git fetch upstream pull/N/head:pr-N && git checkout pr-N && git rebase master`
9898

9999

100100
## best practices

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.