Commit 97d0817
lib: avoid REPL exit on completion error
If a tab completion is attempted on an undefined reference inside of a
function, the REPL was exiting without reporting an error or anything
else. This change results in the REPL reporting the ReferenceError and
continuing.
Fixes: #3346
PR-URL: #3358
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent ff9ef89 commit 97d0817Copy full SHA for 97d0817
File tree
Expand file treeCollapse file tree
2 files changed
+51
-5
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+51
-5
lines changedOpen diff view settings
Collapse file
+10-5Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
32 | 32 | |
33 | 33 | |
34 | 34 | |
| 35 | + |
| 36 | + |
35 | 37 | |
36 | 38 | |
37 | 39 | |
| ||
189 | 191 | |
190 | 192 | |
191 | 193 | |
192 | | - |
193 | | - |
194 | | - |
195 | | - |
196 | | - |
| 194 | + |
| 195 | + |
| 196 | + |
| 197 | + |
| 198 | + |
| 199 | + |
197 | 200 | |
198 | 201 | |
199 | 202 | |
| ||
472 | 475 | |
473 | 476 | |
474 | 477 | |
| 478 | + |
475 | 479 | |
476 | 480 | |
477 | 481 | |
| ||
601 | 605 | |
602 | 606 | |
603 | 607 | |
| 608 | + |
604 | 609 | |
605 | 610 | |
606 | 611 | |
|
Collapse file
test/parallel/test-repl-tab-complete-crash.js
Copy file name to clipboard+41Lines changed: 41 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
| 32 | + |
| 33 | + |
| 34 | + |
| 35 | + |
| 36 | + |
| 37 | + |
| 38 | + |
| 39 | + |
| 40 | + |
| 41 | + |
0 commit comments