nodejs
diff --git a/Collapse file
‎lib/internal/repl.js‎
Copy file name to clipboardExpand all lines: lib/internal/repl.js
+4-1Lines changed: 4 additions & 1 deletion b/Collapse file
‎lib/internal/repl.js‎
Copy file name to clipboardExpand all lines: lib/internal/repl.js
+4-1Lines changed: 4 additions & 1 deletion
diff --git a/Collapse file
‎test/parallel/test-repl-envvars.js‎
Copy file name to clipboard
+55Lines changed: 55 additions & 0 deletions b/Collapse file
‎test/parallel/test-repl-envvars.js‎
Copy file name to clipboard
+55Lines changed: 55 additions & 0 deletions
@@ -34,7 +34,10 @@ function createRepl(env, opts, cb) {
   if (parseInt(env.NODE_NO_READLINE)) {
     opts.terminal = false;
   }
-  if (parseInt(env.NODE_DISABLE_COLORS)) {
+  // the "dumb" special terminal, as defined by terminfo, doesn't support
+  // ANSI colour control codes.
+  // see http://invisible-island.net/ncurses/terminfo.ti.html#toc-_Specials
+  if (parseInt(env.NODE_DISABLE_COLORS) || env.TERM === 'dumb') {
     opts.useColors = false;
   }
 
 
@@ -0,0 +1,55 @@
+'use strict';
+
+// Flags: --expose-internals
+
+const common = require('../common');
+const stream = require('stream');
+const REPL = require('internal/repl');
+const assert = require('assert');
+const inspect = require('util').inspect;
+
+const tests = [{
+  env: {},
+  expected: { terminal: true, useColors: true }
+},
+{
+  env: { NODE_DISABLE_COLORS: '1' },
+  expected: { terminal: true, useColors: false }
+},
+{
+  env: { NODE_NO_READLINE: '1' },
+  expected: { terminal: false, useColors: false }
+},
+{
+  env: { TERM: 'dumb' },
+  expected: { terminal: true, useColors: false }
+},
+{
+  env: { NODE_NO_READLINE: '1', NODE_DISABLE_COLORS: '1' },
+  expected: { terminal: false, useColors: false }
+},
+{
+  env: { NODE_NO_READLINE: '0' },
+  expected: { terminal: true, useColors: true }
+}];
+
+function run(test) {
+  const env = test.env;
+  const expected = test.expected;
+  const opts = {
+    terminal: true,
+    input: new stream.Readable({ read() {} }),
+    output: new stream.Writable({ write() {} })
+  };
+
+  REPL.createInternalRepl(env, opts, function(err, repl) {
+    if (err) throw err;
+    assert.equal(expected.terminal, repl.terminal,
+                 'Expected ' + inspect(expected) + ' with ' + inspect(env));
+    assert.equal(expected.useColors, repl.useColors,
+                 'Expected ' + inspect(expected) + ' with ' + inspect(env));
+    repl.close();
+  });
+}
+
+tests.forEach(run);
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,10 @@ function createRepl(env, opts, cb) {`
`34`	`34`	`if (parseInt(env.NODE_NO_READLINE)) {`
`35`	`35`	`opts.terminal = false;`
`36`	`36`	`}`
`37`		`- if (parseInt(env.NODE_DISABLE_COLORS)) {`
	`37`	`+ // the "dumb" special terminal, as defined by terminfo, doesn't support`
	`38`	`+ // ANSI colour control codes.`
	`39`	`+ // see http://invisible-island.net/ncurses/terminfo.ti.html#toc-_Specials`
	`40`	`+ if (parseInt(env.NODE_DISABLE_COLORS) \|\| env.TERM === 'dumb') {`
`38`	`41`	`opts.useColors = false;`
`39`	`42`	`}`
`40`	`43`