Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9757888

Browse filesBrowse files
tony-goruyadorno
authored andcommitted
doc: fix commit message using test instead of deps
PR-URL: #46313 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 360a3f3 commit 9757888
Copy full SHA for 9757888

File tree

Expand file treeCollapse file tree

2 files changed

+9
-9
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+9
-9
lines changed
Open diff view settings
Collapse file

‎.github/workflows/tools.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/tools.yml
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ jobs:
7878
./tools/update-undici.sh
7979
fi
8080
- id: postject
81-
subsystem: deps
82-
label: dependencies
81+
subsystem: test
82+
label: test
8383
run: |
8484
NEW_VERSION=$(npm view postject dist-tags.latest)
8585
CURRENT_VERSION=$(node -p "require('./test/fixtures/postject-copy/node_modules/postject/package.json').version")
Collapse file

‎doc/contributing/maintaining-postject.md‎

Copy file name to clipboardExpand all lines: doc/contributing/maintaining-postject.md
+7-7Lines changed: 7 additions & 7 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ Check that Node.js still builds and tests.
1212

1313
## Committing postject
1414

15-
Add postject: `git add --all test/fixtures/postject-copy`
15+
1. Add postject: `git add --all test/fixtures/postject-copy`.
16+
2. Commit the changes: `git commit`.
17+
3. Add a message like:
1618

17-
Commit the changes with a message like:
19+
```text
20+
test: update postject to <version>
1821
19-
```text
20-
deps: update postject to 1.0.0-alpha.4
21-
22-
Updated as described in doc/contributing/maintaining-postject.md.
23-
```
22+
Updated as described in doc/contributing/maintaining-postject.md.
23+
```

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.