Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 96a3804

Browse filesBrowse files
mhdawsonaduh95
authored andcommitted
test: increase spin for eventloop test on s390
It was excluded as it was failing intermittently. Likely that s390 was just so fast times were rounded down to 0. Increase the spin time on s390x only. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #56228 Refs: #41286 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent c062ffc commit 96a3804
Copy full SHA for 96a3804

File tree

Expand file treeCollapse file tree

2 files changed

+5
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+5
-4
lines changed
Open diff view settings
Collapse file

‎test/sequential/sequential.status‎

Copy file name to clipboardExpand all lines: test/sequential/sequential.status
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,3 @@ test-tls-securepair-client: PASS, FLAKY
4848
[$arch==arm]
4949
# https://github.com/nodejs/node/issues/49933
5050
test-watch-mode-inspect: SKIP
51-
52-
[$arch==s390x]
53-
# https://github.com/nodejs/node/issues/41286
54-
test-performance-eventloopdelay: PASS, FLAKY
Collapse file

‎test/sequential/test-performance-eventloopdelay.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-performance-eventloopdelay.js
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
const common = require('../common');
55
const assert = require('assert');
6+
const os = require('os');
67
const {
78
monitorEventLoopDelay
89
} = require('perf_hooks');
@@ -51,9 +52,13 @@ const { sleep } = require('internal/util');
5152
}
5253

5354
{
55+
const s390x = os.arch() === 's390x';
5456
const histogram = monitorEventLoopDelay({ resolution: 1 });
5557
histogram.enable();
5658
let m = 5;
59+
if (s390x) {
60+
m = m * 2;
61+
}
5762
function spinAWhile() {
5863
sleep(1000);
5964
if (--m > 0) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.