Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 964dff8

Browse filesBrowse files
addaleaxtargos
authored andcommitted
http2: remove unused FlushData() function
PR-URL: #29145 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent f9b61d2 commit 964dff8
Copy full SHA for 964dff8

File tree

Expand file treeCollapse file tree

2 files changed

+0
-10
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+0
-10
lines changed
Open diff view settings
Collapse file

‎src/node_http2.cc‎

Copy file name to clipboardExpand all lines: src/node_http2.cc
-9Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2723,14 +2723,6 @@ void Http2Stream::Destroy(const FunctionCallbackInfo<Value>& args) {
27232723
stream->Destroy();
27242724
}
27252725

2726-
// Prompt the Http2Stream to begin sending data to the JS land.
2727-
void Http2Stream::FlushData(const FunctionCallbackInfo<Value>& args) {
2728-
Http2Stream* stream;
2729-
ASSIGN_OR_RETURN_UNWRAP(&stream, args.Holder());
2730-
stream->ReadStart();
2731-
Debug(stream, "data flushed to js");
2732-
}
2733-
27342726
// Initiate a Push Promise and create the associated Http2Stream
27352727
void Http2Stream::PushPromise(const FunctionCallbackInfo<Value>& args) {
27362728
Environment* env = Environment::GetCurrent(args);
@@ -3129,7 +3121,6 @@ void Initialize(Local<Object> target,
31293121
stream->SetClassName(FIXED_ONE_BYTE_STRING(env->isolate(), "Http2Stream"));
31303122
env->SetProtoMethod(stream, "id", Http2Stream::GetID);
31313123
env->SetProtoMethod(stream, "destroy", Http2Stream::Destroy);
3132-
env->SetProtoMethod(stream, "flushData", Http2Stream::FlushData);
31333124
env->SetProtoMethod(stream, "priority", Http2Stream::Priority);
31343125
env->SetProtoMethod(stream, "pushPromise", Http2Stream::PushPromise);
31353126
env->SetProtoMethod(stream, "info", Http2Stream::Info);
Collapse file

‎src/node_http2.h‎

Copy file name to clipboardExpand all lines: src/node_http2.h
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,6 @@ class Http2Stream : public AsyncWrap,
581581
// JavaScript API
582582
static void GetID(const FunctionCallbackInfo<Value>& args);
583583
static void Destroy(const FunctionCallbackInfo<Value>& args);
584-
static void FlushData(const FunctionCallbackInfo<Value>& args);
585584
static void Priority(const FunctionCallbackInfo<Value>& args);
586585
static void PushPromise(const FunctionCallbackInfo<Value>& args);
587586
static void RefreshState(const FunctionCallbackInfo<Value>& args);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.