Commit 95faa55
url: check forEach callback is a function
The Web IDL spec mandates such a check.
Also make error messages consistent with rest of Node.js and add
additional tests for forEach().
PR-URL: #10905
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>1 parent 8778fca commit 95faa55Copy full SHA for 95faa55
File tree
Expand file treeCollapse file tree
2 files changed
+22
-10
lines changedOpen diff view settings
Filter options
- lib/internal
- test/parallel
Expand file treeCollapse file tree
2 files changed
+22
-10
lines changedOpen diff view settings
Collapse file
+8-10Lines changed: 8 additions & 10 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
672 | 672 | |
673 | 673 | |
674 | 674 | |
675 | | - |
676 | | - |
| 675 | + |
677 | 676 | |
678 | 677 | |
679 | 678 | |
| ||
687 | 686 | |
688 | 687 | |
689 | 688 | |
690 | | - |
| 689 | + |
691 | 690 | |
692 | 691 | |
693 | 692 | |
| ||
708 | 707 | |
709 | 708 | |
710 | 709 | |
711 | | - |
712 | | - |
| 710 | + |
713 | 711 | |
714 | 712 | |
715 | 713 | |
| ||
749 | 747 | |
750 | 748 | |
751 | 749 | |
752 | | - |
| 750 | + |
753 | 751 | |
754 | 752 | |
755 | 753 | |
| ||
767 | 765 | |
768 | 766 | |
769 | 767 | |
770 | | - |
| 768 | + |
771 | 769 | |
772 | 770 | |
773 | 771 | |
| ||
786 | 784 | |
787 | 785 | |
788 | 786 | |
789 | | - |
| 787 | + |
790 | 788 | |
791 | 789 | |
792 | 790 | |
| ||
814 | 812 | |
815 | 813 | |
816 | 814 | |
817 | | - |
818 | | - |
| 815 | + |
| 816 | + |
819 | 817 | |
820 | 818 | |
821 | 819 | |
|
Collapse file
test/parallel/test-whatwg-url-searchparams.js
Copy file name to clipboardExpand all lines: test/parallel/test-whatwg-url-searchparams.js+14Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
44 | 44 | |
45 | 45 | |
46 | 46 | |
| 47 | + |
| 48 | + |
| 49 | + |
| 50 | + |
| 51 | + |
| 52 | + |
| 53 | + |
| 54 | + |
| 55 | + |
| 56 | + |
| 57 | + |
| 58 | + |
| 59 | + |
| 60 | + |
47 | 61 | |
48 | 62 | |
49 | 63 | |
0 commit comments