Commit 95f6467
module: fix cyclical dynamic import
ensures that instantiation result is only used during initial loading
PR-URL: #18965
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 4b34b2e commit 95f6467Copy full SHA for 95f6467
File tree
Expand file treeCollapse file tree
2 files changed
+7
-3
lines changedOpen diff view settings
Filter options
- lib/internal/loader
- test/es-module
Expand file treeCollapse file tree
2 files changed
+7
-3
lines changedOpen diff view settings
Collapse file
lib/internal/loader/ModuleJob.js
Copy file name to clipboardExpand all lines: lib/internal/loader/ModuleJob.js+4-3Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
50 | 50 | |
51 | 51 | |
52 | 52 | |
53 | | - |
54 | | - |
| 53 | + |
| 54 | + |
55 | 55 | |
56 | | - |
| 56 | + |
| 57 | + |
57 | 58 | |
58 | 59 | |
59 | 60 | |
|
Collapse file
test/es-module/test-esm-cyclic-dynamic-import.mjs
Copy file name to clipboard+3Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
0 commit comments