Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 95b2a39

Browse filesBrowse files
Trottaddaleax
authored andcommitted
test: remove common.localhostIPv6
common.localhostIPv6 is almost entirely unused and is unnecessary. Remove it. PR-URL: #34373 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 76ba129 commit 95b2a39
Copy full SHA for 95b2a39

File tree

Expand file treeCollapse file tree

2 files changed

+2
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-4
lines changed
Open diff view settings
Collapse file

‎test/common/index.js‎

Copy file name to clipboardExpand all lines: test/common/index.js
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -787,8 +787,6 @@ const common = {
787787
return localhostIPv4;
788788
},
789789

790-
get localhostIPv6() { return '::1'; },
791-
792790
// opensslCli defined lazily to reduce overhead of spawnSync
793791
get opensslCli() {
794792
if (opensslCli !== null) return opensslCli;
Collapse file

‎test/sequential/test-net-connect-local-error.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-net-connect-local-error.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ const optionsIPv4 = {
1414
};
1515

1616
const optionsIPv6 = {
17-
host: common.localhostIPv6,
17+
host: '::1',
1818
port: common.PORT + 2,
1919
localPort: common.PORT + 3,
20-
localAddress: common.localhostIPv6
20+
localAddress: '::1',
2121
};
2222

2323
function onError(err, options) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.