Commit 9534f6d
committed
tools: enable additional lint rules
Enable additional likely-uncontroversial lint rules:
* `comma-dangle` set to prohibit dangling commas on objects and arrays
that are defined on a single line. Multi-line definitions can use or
omit a trailing comma.
* `no-unused-labels` Prohibits defining a label that is not used.
* `no-path-concat` Prohibits string-concatenation using i`__dirname` and
`__filename`. Use `path.join()`, `path.resolve()`, or template strings
instead.
* `no-new-symbol` disallow use of `new` operator with `Symbol` object.
Violating this rule would result in a `TypeError` at runtime.`
PR-URL: #5357
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>1 parent 7b0a83d commit 9534f6dCopy full SHA for 9534f6d
File tree
Expand file treeCollapse file tree
4 files changed
+7
-3
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
4 files changed
+7
-3
lines changedOpen diff view settings
Collapse file
+4Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
5 | 5 | |
6 | 6 | |
7 | 7 | |
| 8 | + |
8 | 9 | |
9 | 10 | |
10 | 11 | |
| ||
30 | 31 | |
31 | 32 | |
32 | 33 | |
| 34 | + |
33 | 35 | |
34 | 36 | |
35 | 37 | |
| ||
41 | 43 | |
42 | 44 | |
43 | 45 | |
| 46 | + |
44 | 47 | |
45 | 48 | |
46 | 49 | |
| ||
71 | 74 | |
72 | 75 | |
73 | 76 | |
| 77 | + |
74 | 78 | |
75 | 79 | |
76 | 80 | |
|
Collapse file
test/parallel/test-fs-access.js
Copy file name to clipboardExpand all lines: test/parallel/test-fs-access.js+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
3 | 3 | |
4 | 4 | |
5 | 5 | |
6 | | - |
| 6 | + |
7 | 7 | |
8 | 8 | |
9 | 9 | |
|
Collapse file
test/parallel/test-fs-stat.js
Copy file name to clipboardExpand all lines: test/parallel/test-fs-stat.js+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
68 | 68 | |
69 | 69 | |
70 | 70 | |
71 | | - |
| 71 | + |
72 | 72 | |
73 | 73 | |
74 | 74 | |
|
Collapse file
test/parallel/test-stdio-closed.js
Copy file name to clipboardExpand all lines: test/parallel/test-stdio-closed.js+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
18 | 18 | |
19 | 19 | |
20 | 20 | |
21 | | - |
| 21 | + |
22 | 22 | |
23 | 23 | |
24 | 24 | |
|
0 commit comments