Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 94a486a

Browse filesBrowse files
targosevanlucas
authored andcommitted
build: add v8 requirement to test-v8* in Makefile
The test targets expect that V8 is built in deps/v8/out Ref: #7477 PR-URL: #7482 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent e562727 commit 94a486a
Copy full SHA for 94a486a

File tree

Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -246,22 +246,22 @@ test-timers-clean:
246246

247247

248248
ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
249-
test-v8:
249+
test-v8: v8
250250
# note: performs full test unless QUICKCHECK is specified
251251
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
252252
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \
253253
--no-presubmit \
254254
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
255255
$(TAP_V8)
256256

257-
test-v8-intl:
257+
test-v8-intl: v8
258258
# note: performs full test unless QUICKCHECK is specified
259259
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
260260
--mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \
261261
--shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \
262262
$(TAP_V8_INTL)
263263

264-
test-v8-benchmarks:
264+
test-v8-benchmarks: v8
265265
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \
266266
--download-data $(QUICKCHECK_ARG) --no-presubmit \
267267
--shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) benchmarks \

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.