Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 93f77cb

Browse filesBrowse files
TerrorJackMoLow
TerrorJack
authored and
MoLow
committed
build: set v8_enable_webassembly=false when lite mode is enabled
We should set v8_enable_webassembly=false when lite mode is enabled, since v8_enable_lite_mode implies v8_jitless, and wasm currently doesn't work with jitless. This is automatically handled in gn, but seems to be not the case in gyp. Enabling lite mode without setting v8_enable_webassembly=false leads to "Warning: disabling flag --expose_wasm due to conflicting flags" at runtime. PR-URL: #48248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 36bf069 commit 93f77cb
Copy full SHA for 93f77cb

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1524,7 +1524,7 @@ def configure_library(lib, output, pkgname=None):
15241524

15251525

15261526
def configure_v8(o):
1527-
o['variables']['v8_enable_webassembly'] = 1
1527+
o['variables']['v8_enable_webassembly'] = 0 if options.v8_lite_mode else 1
15281528
o['variables']['v8_enable_javascript_promise_hooks'] = 1
15291529
o['variables']['v8_enable_lite_mode'] = 1 if options.v8_lite_mode else 0
15301530
o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.