Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 93d7fa3

Browse filesBrowse files
committed
test: only inspect on failure
The inspection was done in all cases so far and that's not necessary. Therefore this changed this behavior to only inspect the input on failure cases. PR-URL: #26360 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent b6355ef commit 93d7fa3
Copy full SHA for 93d7fa3

File tree

Expand file treeCollapse file tree

2 files changed

+10
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+10
-8
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-path-join.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-path-join.js
+4-3Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,11 +131,12 @@ joinTests.forEach((test) => {
131131
} else {
132132
os = 'posix';
133133
}
134-
const message =
135-
`path.${os}.join(${test[0].map(JSON.stringify).join(',')})\n expect=${
134+
if (actual !== expected && actualAlt !== expected) {
135+
const delimiter = test[0].map(JSON.stringify).join(',');
136+
const message = `path.${os}.join(${delimiter})\n expect=${
136137
JSON.stringify(expected)}\n actual=${JSON.stringify(actual)}`;
137-
if (actual !== expected && actualAlt !== expected)
138138
failures.push(`\n${message}`);
139+
}
139140
});
140141
});
141142
});
Collapse file

‎test/parallel/test-path-relative.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-path-relative.js
+6-5Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,13 @@ relativeTests.forEach((test) => {
5656
test[1].forEach((test) => {
5757
const actual = relative(test[0], test[1]);
5858
const expected = test[2];
59-
const os = relative === path.win32.relative ? 'win32' : 'posix';
60-
const message = `path.${os}.relative(${
61-
test.slice(0, 2).map(JSON.stringify).join(',')})\n expect=${
62-
JSON.stringify(expected)}\n actual=${JSON.stringify(actual)}`;
63-
if (actual !== expected)
59+
if (actual !== expected) {
60+
const os = relative === path.win32.relative ? 'win32' : 'posix';
61+
const message = `path.${os}.relative(${
62+
test.slice(0, 2).map(JSON.stringify).join(',')})\n expect=${
63+
JSON.stringify(expected)}\n actual=${JSON.stringify(actual)}`;
6464
failures.push(`\n${message}`);
65+
}
6566
});
6667
});
6768
assert.strictEqual(failures.length, 0, failures.join(''));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.