Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 93bacfd

Browse filesBrowse files
aaynTrott
authored andcommitted
test: remove unneeded bind() and related comments
As mentioned in the comment of the changed file, "a libuv limitation makes it necessary to bind()". But, that is not the case in this test. The subsequent call to send() results in an implicit bind(). PR-URL: #5023 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
1 parent 98b721e commit 93bacfd
Copy full SHA for 93bacfd

File tree

Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed
Open diff view settings
Collapse file

‎test/internet/test-dgram-multicast-multi-process.js‎

Copy file name to clipboardExpand all lines: test/internet/test-dgram-multicast-multi-process.js
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,6 @@ if (process.argv[2] !== 'child') {
132132
}
133133

134134
var sendSocket = dgram.createSocket('udp4');
135-
// FIXME: a libuv limitation makes it necessary to bind()
136-
// before calling any of the set*() functions. The bind()
137-
// call is what creates the actual socket.
138-
sendSocket.bind();
139135

140136
// The socket is actually created async now.
141137
sendSocket.on('listening', function() {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.