Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 92ecbc4

Browse filesBrowse files
stefanmbjasnell
authored andcommitted
build: cherry pick V8 change for windows DLL support
PR-URL: #8084 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 4e4c091 commit 92ecbc4
Copy full SHA for 92ecbc4

File tree

Expand file treeCollapse file tree

1 file changed

+4
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-3
lines changed
Open diff view settings
Collapse file

‎deps/v8/build/toolchain.gypi‎

Copy file name to clipboardExpand all lines: deps/v8/build/toolchain.gypi
+4-3Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
'ubsan_vptr%': 0,
4040
'v8_target_arch%': '<(target_arch)',
4141
'v8_host_byteorder%': '<!(python -c "import sys; print sys.byteorder")',
42+
'force_dynamic_crt%': 0,
4243
# Native Client builds currently use the V8 ARM JIT and
4344
# arm/simulator-arm.cc to defer the significant effort required
4445
# for NaCl JIT support. The nacl_target_arch variable provides
@@ -1104,7 +1105,7 @@
11041105
'VCCLCompilerTool': {
11051106
'Optimization': '0',
11061107
'conditions': [
1107-
['component=="shared_library"', {
1108+
['component=="shared_library" or force_dynamic_crt==1', {
11081109
'RuntimeLibrary': '3', # /MDd
11091110
}, {
11101111
'RuntimeLibrary': '1', # /MTd
@@ -1156,7 +1157,7 @@
11561157
'StringPooling': 'true',
11571158
'BasicRuntimeChecks': '0',
11581159
'conditions': [
1159-
['component=="shared_library"', {
1160+
['component=="shared_library" or force_dynamic_crt==1', {
11601161
'RuntimeLibrary': '3', #/MDd
11611162
}, {
11621163
'RuntimeLibrary': '1', #/MTd
@@ -1346,7 +1347,7 @@
13461347
'FavorSizeOrSpeed': '0',
13471348
'StringPooling': 'true',
13481349
'conditions': [
1349-
['component=="shared_library"', {
1350+
['component=="shared_library" or force_dynamic_crt==1', {
13501351
'RuntimeLibrary': '2', #/MD
13511352
}, {
13521353
'RuntimeLibrary': '0', #/MT

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.