Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 929e8df

Browse filesBrowse files
pd4d10danielleadams
authored andcommitted
test: improve coverage of stream.Readable
PR-URL: #38702 Refs: https://coverage.nodejs.org/coverage-0996eb71edbd47d9/lib/internal/streams/readable.js.html#L401 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent bad4d44 commit 929e8df
Copy full SHA for 929e8df

File tree

Expand file treeCollapse file tree

1 file changed

+13
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+13
-0
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-streams-highwatermark.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-streams-highwatermark.js
+13Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,3 +57,16 @@ const { inspect } = require('util');
5757
readable._read = common.mustCall();
5858
readable.read(0);
5959
}
60+
61+
{
62+
// Parse size as decimal integer
63+
['1', '1.0', 1].forEach((size) => {
64+
const readable = new stream.Readable({
65+
read: common.mustCall(),
66+
highWaterMark: 0,
67+
});
68+
readable.read(size);
69+
70+
assert.strictEqual(readable._readableState.highWaterMark, Number(size));
71+
});
72+
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.