Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9271f23

Browse filesBrowse files
committed
doc: update maintaining ICU guide
Do not ask to separate the changes in deps/icu-small and in the LICENSE file. Do not ask to remove the whitespace changes. The way commits are landed now doesn't eliminate them anymore. PR-URL: #40658 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 8e52563 commit 9271f23
Copy full SHA for 9271f23

File tree

Expand file treeCollapse file tree

1 file changed

+3
-9
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-9
lines changed
Open diff view settings
Collapse file

‎doc/guides/maintaining-icu.md‎

Copy file name to clipboardExpand all lines: doc/guides/maintaining-icu.md
+3-9Lines changed: 3 additions & 9 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,7 @@ new Intl.DateTimeFormat('es', { month: 'long' }).format(new Date(9E8));
159159

160160
(This should print your updated ICU version number, and also `enero` again.)
161161

162-
You are ready to check in the updated `deps/icu-small`. This is a big commit,
163-
so make this a separate commit from the smaller changes.
162+
You are ready to check in (`git add`) the updated `deps/icu-small`.
164163

165164
> :warning: Do not modify any source code in `deps/icu-small` !
166165
> See section below about floating patches to ICU.
@@ -185,13 +184,8 @@ make
185184
make test-ci
186185
```
187186

188-
* commit the change to `tools/icu/current_ver.dep` and `LICENSE` files.
189-
190-
* To simplify review, I often will “pre-land” this patch, meaning that I run
191-
`curl -L https://github.com/nodejs/node/pull/xxx.patch | git am -3 --whitespace=fix`
192-
per the collaborator’s guide… and then push that patched branch into my
193-
PR's branch. This reduces the whitespace changes that show up in the PR,
194-
since the final land will eliminate those anyway.
187+
* Commit the change to the `deps/icu-small`, `tools/icu/current_ver.dep`
188+
and `LICENSE` files.
195189

196190
## Floating patches to ICU
197191

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.