Commit 91f2cf9
child_process: fix stdio sockets creation
`readable` and `writable` properties can be passed directly to the
`net.Socket` constructor. This change also avoids an unnecessary call
to `read(0)` on the `stdin` socket. This behavior was disclosed when
trying to merge `libuv@1.19.0` and specifically this commit:
libuv/libuv@fd04939.
PR-URL: #18701
Refs: libuv/libuv#1655
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 0fc33fb commit 91f2cf9Copy full SHA for 91f2cf9
File tree
Expand file treeCollapse file tree
2 files changed
+2
-12
lines changedOpen diff view settings
Filter options
- lib/internal
- test/async-hooks
Expand file treeCollapse file tree
2 files changed
+2
-12
lines changedOpen diff view settings
Collapse file
lib/internal/child_process.js
Copy file name to clipboardExpand all lines: lib/internal/child_process.js+1-11Lines changed: 1 addition & 11 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
238 | 238 | |
239 | 239 | |
240 | 240 | |
241 | | - |
242 | | - |
243 | | - |
244 | | - |
245 | | - |
246 | | - |
247 | | - |
248 | | - |
249 | | - |
250 | | - |
251 | | - |
| 241 | + |
252 | 242 | |
253 | 243 | |
254 | 244 | |
|
Collapse file
test/async-hooks/test-pipewrap.js
Copy file name to clipboardExpand all lines: test/async-hooks/test-pipewrap.js+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
78 | 78 | |
79 | 79 | |
80 | 80 | |
81 | | - |
| 81 | + |
82 | 82 | |
83 | 83 | |
84 | 84 | |
|
0 commit comments