Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 91ccbf0

Browse filesBrowse files
committed
configure: v8_use_snapshot should be true
`v8_use_snapshot` should be either `true` or `false`, not 1 or 0. PR-URL: #3962 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
1 parent c83d9b7 commit 91ccbf0
Copy full SHA for 91ccbf0

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎configure‎

Copy file name to clipboardExpand all lines: configure
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -777,7 +777,7 @@ def configure_v8(o):
777777
o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs.
778778
o['variables']['v8_optimized_debug'] = 0 # Compile with -O0 in debug builds.
779779
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
780-
o['variables']['v8_use_snapshot'] = 0 if options.without_snapshot else 1
780+
o['variables']['v8_use_snapshot'] = 'false' if options.without_snapshot else 'true'
781781

782782
def configure_openssl(o):
783783
o['variables']['node_use_openssl'] = b(not options.without_ssl)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.