Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 915d7ae

Browse filesBrowse files
RafaelGSStargos
authored andcommitted
src: set signal inspector io thread name
PR-URL: #56416 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
1 parent f4b086d commit 915d7ae
Copy full SHA for 915d7ae

File tree

Expand file treeCollapse file tree

3 files changed

+5
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+5
-2
lines changed
Open diff view settings
Collapse file

‎doc/api/worker_threads.md‎

Copy file name to clipboardExpand all lines: doc/api/worker_threads.md
+3-1Lines changed: 3 additions & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1235,7 +1235,9 @@ changes:
12351235
* Maximum sizes:
12361236
* Windows: 32,767 characters
12371237
* macOS: 64 characters
1238-
* Other systems: 16 characters
1238+
* Linux: 16 characters
1239+
* NetBSD: limited to `PTHREAD_MAX_NAMELEN_NP`
1240+
* FreeBSD and OpenBSD: limited to `MAXCOMLEN`
12391241
**Default:** `'WorkerThread'`.
12401242

12411243
### Event: `'error'`
Collapse file

‎src/inspector_agent.cc‎

Copy file name to clipboardExpand all lines: src/inspector_agent.cc
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ static void StartIoThreadWakeup(int signo, siginfo_t* info, void* ucontext) {
8686
}
8787

8888
inline void* StartIoThreadMain(void* unused) {
89+
uv_thread_setname("SignalInspector");
8990
for (;;) {
9091
uv_sem_wait(&start_io_thread_semaphore);
9192
Mutex::ScopedLock lock(start_io_thread_async_mutex);
Collapse file

‎src/inspector_io.cc‎

Copy file name to clipboardExpand all lines: src/inspector_io.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ void InspectorIo::ThreadMain() {
286286
int thread_name_error = uv_thread_setname("InspectorIo");
287287
if (!thread_name_error) [[unlikely]] {
288288
per_process::Debug(node::DebugCategory::INSPECTOR_SERVER,
289-
"Failed to set thread name for Inspector\n");
289+
"Failed to set thread name for Inspector\n");
290290
}
291291
uv_loop_t loop;
292292
loop.data = nullptr;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.