Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 9085412

Browse filesBrowse files
joyeecheungBridgeAR
joyeecheung
authored and
BridgeAR
committed
tools: assert that the snapshot can be rehashed in node_mksnapshot
PR-URL: #28181 Refs: #27365 Refs: #17058 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 833d3d5 commit 9085412
Copy full SHA for 9085412

File tree

Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Collapse file

‎tools/snapshot/snapshot_builder.cc‎

Copy file name to clipboardExpand all lines: tools/snapshot/snapshot_builder.cc
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ std::string SnapshotBuilder::Generate(
9696
// Must be out of HandleScope
9797
StartupData blob =
9898
creator.CreateBlob(SnapshotCreator::FunctionCodeHandling::kClear);
99+
CHECK(blob.CanBeRehashed());
99100
// Must be done while the snapshot creator isolate is entered i.e. the
100101
// creator is still alive.
101102
main_instance->Dispose();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.