Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8f9fb81

Browse filesBrowse files
danbevevanlucas
authored andcommitted
src: updating references to the old node.js file
The node.js script was renamed to bootstrap_node.js as part of 81b6882. Several comments were missed in src/node.cc that referred to the old file name. This commit updates the comments to refer to bootstrap_node.js and correct the path to this file where used. It also moves a comment that seems to have drifted in the file. PR-URL: #8092 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent a146e68 commit 8f9fb81
Copy full SHA for 8f9fb81

File tree

Expand file treeCollapse file tree

1 file changed

+5
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-5
lines changed
Open diff view settings
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
+5-5Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3439,7 +3439,6 @@ void LoadEnvironment(Environment* env) {
34393439
env->isolate()->SetFatalErrorHandler(node::OnFatalError);
34403440
env->isolate()->AddMessageListener(OnMessage);
34413441

3442-
// The node.js file returns a function 'f'
34433442
atexit(AtExit);
34443443

34453444
TryCatch try_catch(env->isolate());
@@ -3459,16 +3458,17 @@ void LoadEnvironment(Environment* env) {
34593458
ReportException(env, try_catch);
34603459
exit(10);
34613460
}
3461+
// The bootstrap_node.js file returns a function 'f'
34623462
CHECK(f_value->IsFunction());
34633463
Local<Function> f = Local<Function>::Cast(f_value);
34643464

34653465
// Now we call 'f' with the 'process' variable that we've built up with
3466-
// all our bindings. Inside node.js we'll take care of assigning things to
3467-
// their places.
3466+
// all our bindings. Inside bootstrap_node.js we'll take care of
3467+
// assigning things to their places.
34683468

34693469
// We start the process this way in order to be more modular. Developers
3470-
// who do not like how 'src/node.js' setups the module system but do like
3471-
// Node's I/O bindings may want to replace 'f' with their own function.
3470+
// who do not like how bootstrap_node.js setups the module system but do
3471+
// like Node's I/O bindings may want to replace 'f' with their own function.
34723472

34733473
// Add a reference to the global object
34743474
Local<Object> global = env->context()->Global();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.