Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 8ec0d75

Browse filesBrowse files
alferpaladdaleax
alferpal
authored and
addaleax
committed
src: cleanup unused headers
Node codebase has evolved a lot in the more than 10 years of its existence. As more features (and code) have been added, changed, removed, it's sometimes hard to keep track of what gets used and what not. This commits attempts to clean some of those potentially left-over headers using suggestions from include-what-you-use Refs: #27531 PR-URL: #30328 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 2cf8a7f commit 8ec0d75
Copy full SHA for 8ec0d75
Expand file treeCollapse file tree

22 files changed

+11
-30
lines changed
Open diff view settings
Collapse file

‎src/api/encoding.cc‎

Copy file name to clipboardExpand all lines: src/api/encoding.cc
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#include "node.h"
2-
#include "env-inl.h"
32
#include "string_bytes.h"
43
#include "util-inl.h"
54
#include "v8.h"
Collapse file

‎src/api/utils.cc‎

Copy file name to clipboardExpand all lines: src/api/utils.cc
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
#include "node.h"
2-
#include "node_internals.h"
3-
#include "util-inl.h"
42

53
#include <csignal>
64

Collapse file

‎src/async_wrap.cc‎

Copy file name to clipboardExpand all lines: src/async_wrap.cc
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
#include "util-inl.h"
2828

2929
#include "v8.h"
30-
#include "v8-profiler.h"
3130

3231
using v8::Context;
3332
using v8::DontDelete;
Collapse file

‎src/connect_wrap.cc‎

Copy file name to clipboardExpand all lines: src/connect_wrap.cc
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
#include "connect_wrap.h"
2-
3-
#include "env-inl.h"
42
#include "req_wrap-inl.h"
5-
#include "util-inl.h"
63

74
namespace node {
85

96
using v8::Local;
107
using v8::Object;
118

9+
class Environment;
1210

1311
ConnectWrap::ConnectWrap(Environment* env,
1412
Local<Object> req_wrap_obj,
Collapse file

‎src/connect_wrap.h‎

Copy file name to clipboardExpand all lines: src/connect_wrap.h
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,8 @@
33

44
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
55

6-
#include "env.h"
76
#include "req_wrap-inl.h"
87
#include "async_wrap.h"
9-
#include "v8.h"
108

119
namespace node {
1210

Collapse file

‎src/connection_wrap.h‎

Copy file name to clipboardExpand all lines: src/connection_wrap.h
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
55

66
#include "stream_wrap.h"
7-
#include "v8.h"
87

98
namespace node {
109

Collapse file

‎src/debug_utils.cc‎

Copy file name to clipboardExpand all lines: src/debug_utils.cc
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#include "debug_utils.h"
22
#include "env-inl.h"
3-
#include "util-inl.h"
43

54
#ifdef __POSIX__
65
#if defined(__linux__)
Collapse file

‎src/env.cc‎

Copy file name to clipboardExpand all lines: src/env.cc
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
#include "node_errors.h"
88
#include "node_file.h"
99
#include "node_internals.h"
10-
#include "node_native_module.h"
1110
#include "node_options-inl.h"
1211
#include "node_process.h"
1312
#include "node_v8_platform-inl.h"
Collapse file

‎src/fs_event_wrap.cc‎

Copy file name to clipboardExpand all lines: src/fs_event_wrap.cc
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
#include "async_wrap-inl.h"
2323
#include "env-inl.h"
24-
#include "util-inl.h"
2524
#include "node.h"
2625
#include "handle_wrap.h"
2726
#include "string_bytes.h"
Collapse file

‎src/handle_wrap.cc‎

Copy file name to clipboardExpand all lines: src/handle_wrap.cc
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include "async_wrap-inl.h"
2424
#include "env-inl.h"
2525
#include "util-inl.h"
26-
#include "node.h"
2726

2827
namespace node {
2928

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.