Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 8e91f3e

Browse filesBrowse files
addaleaxBethGriggs
addaleax
authored and
BethGriggs
committed
test: fix test_worker_terminate_finalization
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in #34625. PR-URL: #34726 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
1 parent 230bcaf commit 8e91f3e
Copy full SHA for 8e91f3e

File tree

Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Collapse file

‎test/node-api/test_worker_terminate_finalization/test_worker_terminate_finalization.c‎

Copy file name to clipboardExpand all lines: test/node-api/test_worker_terminate_finalization/test_worker_terminate_finalization.c
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ napi_value Test(napi_env env, napi_callback_info info) {
2222
size_t argc = 1;
2323
napi_value argv[1];
2424
napi_value result;
25-
napi_ref ref;
2625
void* bufferData = malloc(BUFFER_SIZE);
2726

2827
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, argv, NULL, NULL));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.