Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8e5b711

Browse filesBrowse files
BridgeARMylesBorins
authored andcommitted
tools: prohibit notDeepEqual usage
PR-URL: #16325 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 36e2643 commit 8e5b711
Copy full SHA for 8e5b711

File tree

Expand file treeCollapse file tree

2 files changed

+10
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+10
-7
lines changed
Open diff view settings
Collapse file

‎.eslintrc.yaml‎

Copy file name to clipboardExpand all lines: .eslintrc.yaml
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@ rules:
5656
- object: assert
5757
property: deepEqual
5858
message: Use assert.deepStrictEqual().
59+
- object: assert
60+
property: notDeepEqual
61+
message: Use assert.notDeepStrictEqual().
5962
- object: assert
6063
property: equal
6164
message: Use assert.strictEqual() rather than assert.equal().
Collapse file

‎lib/assert.js‎

Copy file name to clipboardExpand all lines: lib/assert.js
+7-7Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -101,20 +101,20 @@ assert.deepEqual = function deepEqual(actual, expected, message) {
101101
innerFail(actual, expected, message, 'deepEqual', deepEqual);
102102
}
103103
};
104-
/* eslint-enable */
105-
106-
assert.deepStrictEqual = function deepStrictEqual(actual, expected, message) {
107-
if (!isDeepStrictEqual(actual, expected)) {
108-
innerFail(actual, expected, message, 'deepStrictEqual', deepStrictEqual);
109-
}
110-
};
111104

112105
// The non-equivalence assertion tests for any deep inequality.
113106
assert.notDeepEqual = function notDeepEqual(actual, expected, message) {
114107
if (isDeepEqual(actual, expected)) {
115108
innerFail(actual, expected, message, 'notDeepEqual', notDeepEqual);
116109
}
117110
};
111+
/* eslint-enable */
112+
113+
assert.deepStrictEqual = function deepStrictEqual(actual, expected, message) {
114+
if (!isDeepStrictEqual(actual, expected)) {
115+
innerFail(actual, expected, message, 'deepStrictEqual', deepStrictEqual);
116+
}
117+
};
118118

119119
assert.notDeepStrictEqual = notDeepStrictEqual;
120120
function notDeepStrictEqual(actual, expected, message) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.