Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8e50413

Browse filesBrowse files
Trottevanlucas
authored andcommitted
test: fix flaky test-fs-read-buffer-tostring-fail
The test is memory intensive and times out occasionally on Raspberry Pi devices in CI. Successful test runs take about 90 seconds, but the devices time out after 120 seconds. That's not a lot of headroom. So let's skip the test on devices that have only modest amounts of memory. Fixes: #7042 PR-URL: #7575 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
1 parent fa99dad commit 8e50413
Copy full SHA for 8e50413

File tree

Expand file treeCollapse file tree

1 file changed

+7
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+7
-0
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-fs-read-buffer-tostring-fail.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-read-buffer-tostring-fail.js
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
'use strict';
22

33
const common = require('../common');
4+
5+
if (!common.enoughTestMem) {
6+
const skipMessage = 'intensive toString tests due to memory confinements';
7+
common.skip(skipMessage);
8+
return;
9+
}
10+
411
const assert = require('assert');
512
const fs = require('fs');
613
const path = require('path');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.