Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8e31bf4

Browse filesBrowse files
joyeecheungMylesBorins
authored andcommitted
util: skip type checks in internal getSystemErrorName
Backport-PR-URL: #18916 PR-URL: #18546 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent b3fe55a commit 8e31bf4
Copy full SHA for 8e31bf4

File tree

Expand file treeCollapse file tree

2 files changed

+9
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+9
-6
lines changed
Open diff view settings
Collapse file

‎lib/internal/util.js‎

Copy file name to clipboardExpand all lines: lib/internal/util.js
-5Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -208,11 +208,6 @@ function getConstructorOf(obj) {
208208
}
209209

210210
function getSystemErrorName(err) {
211-
if (typeof err !== 'number' || err >= 0 || !Number.isSafeInteger(err)) {
212-
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err',
213-
'negative number');
214-
}
215-
216211
const entry = errmap.get(err);
217212
return entry ? entry[0] : `Unknown system error ${err}`;
218213
}
Collapse file

‎lib/util.js‎

Copy file name to clipboardExpand all lines: lib/util.js
+9-1Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ const {
5454
customInspectSymbol,
5555
deprecate,
5656
getConstructorOf,
57-
getSystemErrorName,
57+
getSystemErrorName: internalErrorName,
5858
isError,
5959
promisify,
6060
join,
@@ -1071,6 +1071,14 @@ function callbackify(original) {
10711071
return callbackified;
10721072
}
10731073

1074+
function getSystemErrorName(err) {
1075+
if (typeof err !== 'number' || err >= 0 || !Number.isSafeInteger(err)) {
1076+
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err',
1077+
'negative number');
1078+
}
1079+
return internalErrorName(err);
1080+
}
1081+
10741082
// Keep the `exports =` so that various functions can still be monkeypatched
10751083
module.exports = exports = {
10761084
_errnoException,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.