Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8da3da4

Browse filesBrowse files
Julien Gillirvagg
authored andcommitted
deps: backport ff7d70b from V8's upstream
Original commit message: Update BitField3 type in gen-postmortem-metadata.py Since https://codereview.chromium.org/272163002, BitField3 is a raw uint32 field, and not a SMI anymore. Update tools/gen-postmortem-metadata.py so that post-mortem tools can work with versions of V8 that shipped after that change. This change was merged in github.com/joyent/node right before node v0.12.0 was released. R=danno@chromium.org TEST=mdb_v8, a post-mortem debugging tool running on SmartOS, has been using this change since Node.js v0.12.0 was released BUG= Review URL: https://codereview.chromium.org/1296743003 Cr-Commit-Position: refs/heads/master@{#30839} PR: #2959 PR-URL: #2959 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Rod Vagg <r@va.gg>
1 parent 6ea8ec1 commit 8da3da4
Copy full SHA for 8da3da4

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎deps/v8/tools/gen-postmortem-metadata.py‎

Copy file name to clipboardExpand all lines: deps/v8/tools/gen-postmortem-metadata.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@
146146
'Map, instance_size, int, kInstanceSizeOffset',
147147
'Map, bit_field, char, kBitFieldOffset',
148148
'Map, bit_field2, char, kBitField2Offset',
149-
'Map, bit_field3, SMI, kBitField3Offset',
149+
'Map, bit_field3, int, kBitField3Offset',
150150
'Map, prototype, Object, kPrototypeOffset',
151151
'NameDictionaryShape, prefix_size, int, kPrefixSize',
152152
'NameDictionaryShape, entry_size, int, kEntrySize',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.