Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8d83d80

Browse filesBrowse files
legendecasaduh95
authored andcommitted
build: add temporal test on GHA windows
PR-URL: #61810 Refs: #58730 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
1 parent 8b38718 commit 8d83d80
Copy full SHA for 8d83d80

2 files changed

+8-1Lines changed: 8 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎.github/workflows/coverage-windows.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/coverage-windows.yml
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,14 @@ jobs:
7979
allow-prereleases: true
8080
- name: Install deps
8181
run: choco install nasm
82+
- name: Install Rust ${{ env.RUSTC_VERSION }}
83+
run: |
84+
rustup override set "$RUSTC_VERSION"
85+
rustup --version
8286
- name: Environment Information
8387
run: npx envinfo
8488
- name: Build
85-
run: ./vcbuild.bat clang-cl
89+
run: ./vcbuild.bat clang-cl v8temporal
8690
# TODO(bcoe): investigate tests that fail with coverage enabled
8791
# on Windows.
8892
- name: Test
Collapse file

‎vcbuild.bat‎

Copy file name to clipboardExpand all lines: vcbuild.bat
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ set doc=
7272
set extra_msbuild_args=
7373
set compile_commands=
7474
set cfg=
75+
set v8temporal=
7576
set v8windbg=
7677
set exit_code=0
7778

@@ -97,6 +98,7 @@ if /i "%1"=="sign" set sign=1&goto arg-ok
9798
if /i "%1"=="nosnapshot" set nosnapshot=1&goto arg-ok
9899
if /i "%1"=="nonpm" set nonpm=1&goto arg-ok
99100
if /i "%1"=="ltcg" set ltcg=1&goto arg-ok
101+
if /i "%1"=="v8temporal" set v8temporal=1&goto arg-ok
100102
if /i "%1"=="v8windbg" set v8windbg=1&goto arg-ok
101103
if /i "%1"=="licensertf" set licensertf=1&goto arg-ok
102104
if /i "%1"=="test" set test_args=%test_args% %common_test_suites%&set lint_cpp=1&set lint_js=1&set lint_md=1&goto arg-ok
@@ -214,6 +216,7 @@ if defined DEBUG_HELPER set configure_flags=%configure_flags% --verbose
214216
if defined ccache_path set configure_flags=%configure_flags% --use-ccache-win
215217
if defined compile_commands set configure_flags=%configure_flags% -C
216218
if defined cfg set configure_flags=%configure_flags% --control-flow-guard
219+
if defined v8temporal set configure_flags=%configure_flags% --v8-enable-temporal-support
217220
if defined v8windbg set configure_flags=%configure_flags% --enable-v8windbg
218221

219222
if "%target_arch%"=="x86" (

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.