Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 8c5e951

Browse filesBrowse files
mmarchinitargos
mmarchini
authored and
targos
committed
deps: V8: cherry-pick cc5016e1b702
Original commit message: [postmortem] add metadata for the new DescriptorArray layout R=yangguo@chromium.org Ref: nodejs/llnode#255 Change-Id: Icda271123375db5c381fe1d1bba13dcc26f26d7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832311 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#64169} Refs: v8/v8@cc5016e PR-URL: #30870 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent ccf9038 commit 8c5e951
Copy full SHA for 8c5e951

File tree

Expand file treeCollapse file tree

3 files changed

+6
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+6
-2
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.27',
41+
'v8_embedder_string': '-node.28',
4242

4343
##### V8 defaults for Node.js #####
4444

Collapse file

‎deps/v8/BUILD.gn‎

Copy file name to clipboardExpand all lines: deps/v8/BUILD.gn
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,8 @@ action("postmortem-metadata") {
895895
"src/objects/code.h",
896896
"src/objects/data-handler.h",
897897
"src/objects/data-handler-inl.h",
898+
"src/objects/descriptor-array.h",
899+
"src/objects/descriptor-array-inl.h",
898900
"src/objects/feedback-cell.h",
899901
"src/objects/feedback-cell-inl.h",
900902
"src/objects/fixed-array-inl.h",
Collapse file

‎deps/v8/tools/gen-postmortem-metadata.py‎

Copy file name to clipboardExpand all lines: deps/v8/tools/gen-postmortem-metadata.py
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,7 @@
286286
'Code, instruction_start, uintptr_t, kHeaderSize',
287287
'Code, instruction_size, int, kInstructionSizeOffset',
288288
'String, length, int32_t, kLengthOffset',
289+
'DescriptorArray, header_size, uintptr_t, kHeaderSize',
289290
];
290291

291292
#
@@ -296,7 +297,8 @@
296297
expected_classes = [
297298
'ConsString', 'FixedArray', 'HeapNumber', 'JSArray', 'JSFunction',
298299
'JSObject', 'JSRegExp', 'JSPrimitiveWrapper', 'Map', 'Oddball', 'Script',
299-
'SeqOneByteString', 'SharedFunctionInfo', 'ScopeInfo', 'JSPromise'
300+
'SeqOneByteString', 'SharedFunctionInfo', 'ScopeInfo', 'JSPromise',
301+
'DescriptorArray'
300302
];
301303

302304

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.