Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8c154aa

Browse filesBrowse files
mmarchiniBridgeAR
authored andcommitted
src: allow --interpreted-frames-native-stack in NODE_OPTIONS
PR-URL: #27744 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent f56cd36 commit 8c154aa
Copy full SHA for 8c154aa

File tree

Expand file treeCollapse file tree

3 files changed

+7
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+7
-0
lines changed
Open diff view settings
Collapse file

‎doc/api/cli.md‎

Copy file name to clipboardExpand all lines: doc/api/cli.md
+1Lines changed: 1 addition & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1064,6 +1064,7 @@ Node.js options that are allowed are:
10641064
V8 options that are allowed are:
10651065
<!-- node-options-v8 start -->
10661066
- `--abort-on-uncaught-exception`
1067+
- `--interpreted-frames-native-stack`
10671068
- `--max-old-space-size`
10681069
- `--perf-basic-prof-only-functions`
10691070
- `--perf-basic-prof`
Collapse file

‎src/node_options.cc‎

Copy file name to clipboardExpand all lines: src/node_options.cc
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -563,6 +563,9 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
563563
"for analysis",
564564
V8Option{},
565565
kAllowedInEnvironment);
566+
AddOption("--interpreted-frames-native-stack",
567+
"help system profilers to translate JavaScript interpreted frames",
568+
V8Option{}, kAllowedInEnvironment);
566569
AddOption("--max-old-space-size", "", V8Option{}, kAllowedInEnvironment);
567570
AddOption("--perf-basic-prof", "", V8Option{}, kAllowedInEnvironment);
568571
AddOption("--perf-basic-prof-only-functions",
Collapse file

‎test/parallel/test-cli-node-options.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cli-node-options.js
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@ expect('--stack-trace-limit=100',
6565
/(\s*at f \(\[eval\]:1:\d*\)\r?\n){100}/,
6666
'(function f() { f(); })();',
6767
true);
68+
// Unsupported on arm. See https://crbug.com/v8/8713.
69+
if (!['arm', 'arm64'].includes(process.arch))
70+
expect('--interpreted-frames-native-stack', 'B\n');
6871

6972
function expect(opt, want, command = 'console.log("B")', wantsError = false) {
7073
const argv = ['-e', command];

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.