Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8ab748e

Browse filesBrowse files
ryandesigntargos
authored andcommitted
build: don't use -latomic on macOS
Fixes build when using open-source clang. Builds using Apple clang from Xcode v7 and later were already working, due to the fact that node's build system misidentifies their llvm_version as "0.0" and thus the flag wasn't being added. PR-URL: #30099 Fixes: #30093 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent b48cfcc commit 8ab748e
Copy full SHA for 8ab748e

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎node.gyp‎

Copy file name to clipboardExpand all lines: node.gyp
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@
292292
'-Wl,-bnoerrmsg',
293293
],
294294
}],
295-
['OS in ("linux", "mac") and llvm_version != "0.0"', {
295+
['OS == "linux" and llvm_version != "0.0"', {
296296
'libraries': ['-latomic'],
297297
}],
298298
],

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.