Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8aad81d

Browse filesBrowse files
iam-frankqiuBethGriggs
authored andcommitted
doc: add full list of subsystems
PR-URL: #39971 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
1 parent f666f5a commit 8aad81d
Copy full SHA for 8aad81d

File tree

Expand file treeCollapse file tree

1 file changed

+3
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-0
lines changed
Open diff view settings
Collapse file

‎doc/guides/contributing/pull-requests.md‎

Copy file name to clipboardExpand all lines: doc/guides/contributing/pull-requests.md
+3Lines changed: 3 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -579,6 +579,8 @@ If you want to know more about the code review and the landing process, see the
579579
* `test`
580580
* `tools`
581581

582+
You can find the full list of supported subsystems in the
583+
[nodejs/core-validate-commit][] repository.
582584
More than one subsystem may be valid for any particular issue or pull request.
583585

584586
[Building guide]: ../../../BUILDING.md
@@ -591,5 +593,6 @@ More than one subsystem may be valid for any particular issue or pull request.
591593
[guide for writing tests in Node.js]: ../writing-tests.md
592594
[hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment
593595
[https://ci.nodejs.org/]: https://ci.nodejs.org/
596+
[nodejs/core-validate-commit]: https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js
594597
[pull request template]: https://raw.githubusercontent.com/nodejs/node/HEAD/.github/PULL_REQUEST_TEMPLATE.md
595598
[running tests]: ../../../BUILDING.md#running-tests

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.