Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8a60aa1

Browse filesBrowse files
santigimenorvagg
authored andcommitted
test: don't check the # of chunks in test-http-1.0
As it can happen that the HTTP response is received in more than one TCP chunk. PR-URL: #3961 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
1 parent 8f845ba commit 8a60aa1
Copy full SHA for 8a60aa1

File tree

Expand file treeCollapse file tree

1 file changed

+5
-11
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-11
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-http-1.0.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-1.0.js
+5-11Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,7 @@ function test(handler, request_generator, response_validator) {
1313
var server = http.createServer(handler);
1414

1515
var client_got_eof = false;
16-
var server_response = {
17-
data: '',
18-
chunks: []
19-
};
16+
var server_response = '';
2017

2118
function cleanup() {
2219
server.close();
@@ -36,8 +33,7 @@ function test(handler, request_generator, response_validator) {
3633
});
3734

3835
c.on('data', function(chunk) {
39-
server_response.data += chunk;
40-
server_response.chunks.push(chunk);
36+
server_response += chunk;
4137
});
4238

4339
c.on('end', function() {
@@ -65,7 +61,7 @@ function test(handler, request_generator, response_validator) {
6561
}
6662

6763
function response_validator(server_response, client_got_eof, timed_out) {
68-
var m = server_response.data.split('\r\n\r\n');
64+
var m = server_response.split('\r\n\r\n');
6965
assert.equal(m[1], body);
7066
assert.equal(true, client_got_eof);
7167
assert.equal(false, timed_out);
@@ -107,8 +103,7 @@ function test(handler, request_generator, response_validator) {
107103
'\r\n' +
108104
'Hello, world!');
109105

110-
assert.equal(expected_response, server_response.data);
111-
assert.equal(1, server_response.chunks.length);
106+
assert.equal(expected_response, server_response);
112107
assert.equal(true, client_got_eof);
113108
assert.equal(false, timed_out);
114109
}
@@ -151,8 +146,7 @@ function test(handler, request_generator, response_validator) {
151146
'0\r\n' +
152147
'\r\n');
153148

154-
assert.equal(expected_response, server_response.data);
155-
assert.equal(1, server_response.chunks.length);
149+
assert.equal(expected_response, server_response);
156150
assert.equal(true, client_got_eof);
157151
assert.equal(false, timed_out);
158152
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.